I’m thinking I’ll ditch the theme options for colors and fonts. It’s not the best way to handle such things. As I said in the documentation, these things belong in a child theme. They’re handy for quick mockups, which is how I’ve been using them. But it’s unnecessary overhead in the theme and it’s really not clean. I hacked the options framework to make the fonts work properly with font-face implementations, and I don’t want the burden of maintaining my changes alongside the core options framework. Plus I hate the extra bloat that comes from inline CSS hackery.
10 thoughts on “Status: Thoughts regarding colors and fonts”
Leave a Reply
You must be logged in to post a comment.
I agree.
Marc, I just pushed an update that removes that filth. You can grab the latest beta (.67 as of right now) to get that change.
Thanks for your feedback.
Thank you for this update, i think you are totally right. On the other hand I’d like to sugest a quick setting that allows me to have the sidebar either right (as now) or left. I know I can achieve this with a child theme copying index.html, single.html etc.. but if you ever improve the features and code inside these templates I will not benefit of it in my childtheme . What do you think ?
Hey, cestbibi. I agree. The left/right layout option is something I’ve wanted to add, but just haven’t gotten around to it. In the meantime, you could do something like this with css:
#content { float: right; }
#sidebar { float: left; margin-left: 0 }
That should work, but I haven’t tested it to make sure no display oddities pop up.
Thanks for the feedback. I’ll add this as an option soon.
It would be nice if we could choose this on a per-page or post basis. That is, on a specific page, I could choose to have:
content | sidebar
sidebar | content
full-width content
Hey wjdennen, already working on it. It’s coming soon.
Oh great ! thank you! I’ll use the css meanwhile.
Cheers
As a follow-up, I can say the css hack worked ok so far, only problem was with the search.php template that for some reason as a different markup (than the index.php for example) so I had to modify it to be the same and the css hack to work.
As an idea for the future I think it would be great to have the ability to modify (in settings) the span number for content and sidebar – so for example we can choose it to be 8(content) and 4(sidebar) -, because in some designs you need to have a larger sidebar and now we only can achieve this by copying / modifying all templates to the child theme.
Good eye about the search.php template markup being different. It might be like that on others. I’ll check and update accordingly.
I also like the idea about setting span size. No point in having to maintain a bunch of templates just for that. I’ll do something about that.
Thanks for the feedback.
cestbibi, as of version .73 I have added filters to the content and sidebar container classes which will allow you to easily modify the span sizes.
Example: to change the span9 to span8, you would do the following:
function alienship_custom_content_container() {
return "span8";
}
add_filter('alienship_content_container_class', 'alienship_custom_content_container');
The filter for the sidebar is alienship_sidebar_container_class. Hope this helps.